♻️ refactor(payments): use Notification service for emails ⚠️ 🚨#9042
Merged
giancarloromeo merged 56 commits intoITISFoundation:masterfrom Apr 23, 2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9042 +/- ##
==========================================
+ Coverage 87.40% 87.41% +0.01%
==========================================
Files 2057 2058 +1
Lines 81070 81063 -7
Branches 1461 1461
==========================================
+ Hits 70856 70860 +4
+ Misses 9803 9792 -11
Partials 411 411
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…s' of github.com:giancarloromeo/osparc-simcore into refactor/use-notification-service-for-emails-in-payments
giancarloromeo
changed the title
…s' of github.com:giancarloromeo/osparc-simcore into refactor/use-notification-service-for-emails-in-payments
giancarloromeo
requested review from
YuryHrytsuk,
mrnicegyu11 and
sanderegg
as code owners
GitHK
reviewed
Apr 23, 2026
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
Please have a look at my comment and thanks for considering it.
giancarloromeo
changed the title
matusdrobuliak66
approved these changes
Apr 23, 2026
Collaborator
There was a problem hiding this comment.
Thanks! I reviewed properly this time ;) looking good, lets test it in aws master when it is deployed - you can buy credits with a fake credit card and this should initialize this email .
We can test both cases, successful but also unsuccessful payment - please let me know when it is in master and we can do it together.
Contributor
Author
Yep, I know. Already tested with example_payments_gateway locally... but I put 🚨 in the title to remember that it will require Manual tests also when deployed :) Thanks for reviewing it 🙏 |
pcrespov
approved these changes
Apr 23, 2026
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
thx.
Left some comments. Please keep an eye on them.
|
Contributor
Author
|
@mergify queue |
Contributor
Merge Queue Status
Waiting for:
All conditions
|
Contributor
Author
|
@mrnicegyu11 review, bitte |
giancarloromeo
merged commit 018115f
into
ITISFoundation:master
146 of 148 checks passed
giancarloromeo
deleted the
refactor/use-notification-service-for-emails-in-payments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request refactors payment confirmation emails to be sent through the notifications service (via RabbitMQ RPC + notifications worker) instead of direct SMTP rendering/sending in the payments service, and introduces support for email BCC and attachments across the notifications pipeline.
Before
After
Related issue/s
How to test
Dev-ops
PAYMENTS_EMAILenv var is not used anymore (MR 1989).